Add Unmarshal(cfg string) to VendorConfigManager #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splaspood
force-pushed
the
vcm-unmarshal-0
branch
from
dd3030c
to
cfd9f1a
Compare
joelrebel
reviewed
Jun 26, 2024
| @@ -114,13 +125,208 @@ func (cm *supermicroVendorConfig) Marshal() (string, error) { | |||
| } | |||
| } | |||
|
|
|||
| func (cm *supermicroVendorConfig) Unmarshal(cfgData string) (err error) { | |||
There was a problem hiding this comment.
can you include test cases and some fixture data for these
There was a problem hiding this comment.
I'd like to produce a future PR with test cases for all the config stuff and not block this one for now.
| return | ||
| } | ||
|
|
||
| func normalizeSetting(s *supermicroBiosCfgSetting) (k, v string, err error) { |
There was a problem hiding this comment.
Test cases for this method would help maintain this over time
There was a problem hiding this comment.
Same comment re a future PR.
| } | ||
|
|
||
| func (cm *supermicroVendorConfig) EnableSRIOV() { | ||
| cm.Raw("SR-IOV Support", "Enabled", []string{"Advanced", "PCIe/PCI/PnP Configuration"}) | ||
| func (cm *supermicroVendorConfig) BootOrder(mode string) error { |
…aining generic funcs
splaspood
force-pushed
the
vcm-unmarshal-0
branch
from
168c36c
to
bac336d
Compare
joelrebel
approved these changes
Jul 18, 2024
| Unmarshal(cfgData string) (err error) | ||
| StandardConfig() (biosConfig map[string]string, err error) | ||
|
|
||
| BootMode(mode string) error |
There was a problem hiding this comment.
Would recommend smaller interfaces, so not all vendor implementations are forced to implement all of these
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
Adds a function to each VendorConfigManager with the signature Unmarshal(cfg string) that takes a vendor-specific raw config file (as a string) and parses that content into the vendor specific configuration structs.
Additionally, this commit also provides functions for config/supermicro that convert a vendor specific config file into a generic map[string]string normalized across vendors.
The HW vendor this change applies to (if applicable)
Supermicro primarily.
Description for changelog/release notes