deprecate canvas rotation #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
bmorris3
force-pushed
the
wcs-only-layers
branch
3 times, most recently
from
904dfa7
to
af8cde5
Compare
kecnry
force-pushed
the
deprecate-canvas-rotation
branch
from
2e6abdf
to
05bfc88
Compare
bmorris3
force-pushed
the
wcs-only-layers
branch
from
e1b2b10
to
23552e5
Compare
bmorris3
force-pushed
the
wcs-only-layers
branch
4 times, most recently
from
7b817c4
to
1ed58e7
Compare
pllim
force-pushed
the
wcs-only-layers
branch
from
1ed58e7
to
f565c5a
Compare
bmorris3
force-pushed
the
wcs-only-layers
branch
from
a55d4e2
to
0ff4cc7
Compare
bmorris3
force-pushed
the
wcs-only-layers
branch
2 times, most recently
from
588e459
to
8a168bb
Compare
bmorris3
force-pushed
the
wcs-only-layers
branch
2 times, most recently
from
fd9d67d
to
8a1bbaf
Compare
9 tasks
bmorris3
force-pushed
the
wcs-only-layers
branch
from
9572b49
to
e721d5e
Compare
11 tasks
kecnry
force-pushed
the
deprecate-canvas-rotation
branch
from
05bfc88
to
367a7f7
Compare
bmorris3
force-pushed
the
wcs-only-layers
branch
from
1bd45a7
to
bc3be34
Compare
kecnry
force-pushed
the
deprecate-canvas-rotation
branch
from
367a7f7
to
e42dd48
Compare
kecnry
force-pushed
the
deprecate-canvas-rotation
branch
from
e42dd48
to
a93a753
Compare
kecnry
commented
Nov 27, 2023
* NOTE: will need to update "since" as well as "Links Control" if we decide to rename that as part of this effort.
kecnry
force-pushed
the
deprecate-canvas-rotation
branch
from
a93a753
to
fc930d6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## wcs-only-layers #9 +/- ##
==================================================
Coverage ? 90.23%
==================================================
Files ? 160
Lines ? 19855
Branches ? 0
==================================================
Hits ? 17916
Misses ? 1939
Partials ? 0 ☔ View full report in Codecov by Sentry. |
bmorris3
approved these changes
Nov 27, 2023
|
Unrelated py3.12 failure tracked at spacetelescope#2572. Thanks @kecnry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds deprecation warnings for "Canvas Rotation" into the docs, plugin UI, and plugin user API. Note that we will need to update the version in the deprecation decorator (since this deprecation definitely won't be released in 3.6) as well as update any references to "Links Control" if we decide to rename that as part of this larger effort.
Alternatively we could get this in to main and released in 3.6, but we have nothing to point to as an alternate option yet.