This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
Final support for transaction #11
Open
xadhoom
wants to merge
119
commits into
bmuller:master
Choose a base branch
from
VoiSmart:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: * add transaction support for object deletion (and tests) * add docs
Postgresql tests should work but cannot test right now. TODO: * support transaction on object delete (and add tests) * add docs
added tests.
Conflicts: .gitignore twistar/dbconfig/base.py twistar/tests/test_dbobject.py
Fixed Conflict: twistar/tests/test_utils.py
Hi, |
Conflicts: README.rst setup.py
Conflicts: twistar/dbconfig/base.py
Conflicts: twistar/relationships.py twistar/tests/mysql_config.py
…s and whatever. With tests.
add missing inlineCallbacks decorator to delete_all test
missing inlineCallbacks decorator
add missing inlineCallbacks decorator to test
…tion-message fix exception message when failing to commit
currently connection errors in the {start,commit,rollback}Transaction methods will cause the underlying thread to never stop, causing the pool to eventually exhaust all the resources This fixes the issue by capturing the error, stopping the worker, and propagating back the exception towards the caller
…topped always stop txthreadworker, even after unexpected exceptions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
as discussed in the issues #9, here's the final support for trasactions, along with tests and docs.
Also in sync with current master branch.
Hope all is ok!