[R4R]support Index service recovery and indexHeight in Status api #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
force-pushed
the
index
branch
4 times, most recently
from
c4ed633
to
b291b1b
Compare
unclezoro
changed the title
unclezoro
requested review from
rickyyangz,
ackratos,
yutianwu,
darren-liu and
abelliumnt
abelliumnt
reviewed
Jul 31, 2019
abelliumnt
approved these changes
Jul 31, 2019
ackratos
reviewed
Jul 31, 2019
ackratos
approved these changes
Aug 2, 2019
|
as discussed, please check whether it has any performance impact in high tps |
rickyyangz
requested changes
Aug 5, 2019
rickyyangz
reviewed
Aug 12, 2019
rickyyangz
reviewed
Aug 12, 2019
| // if never store `indexHeight` in index db, will return -1. | ||
| func (ih *IndexHub) GetIndexedHeight() int64 { | ||
| rawHeight := ih.stateDB.Get(indexHeight) | ||
| if rawHeight == nil { |
There was a problem hiding this comment.
remember to fix the state_recover tool
4 tasks
rickyyangz
approved these changes
Aug 12, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rationale
This pr have pass though following testcases:
Example
api of 'Status ' changed:
{ "jsonrpc": "2.0", "id": "", "result": { ... "sync_info": { "latest_block_hash": "F51538DA498299F4C57AC8162AAFA0254CE08286", "latest_app_hash": "0000000000000000", "latest_block_height": "18", "latest_block_time": "2018-09-17T11:42:19.149920551Z", "catching_up": false, "index_height": "18" }, ... }Changes
Preflight checks
make build)make test)Already reviewed by
...
Related issues
@xzjcool @Kaiqiang all other sdk need change the 'status' api response.