improve: remove sharedpool from miner #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzckck
force-pushed
the
remove_sharedpool
branch
from
c84179a
to
fc9fb60
Compare
fynnss
reviewed
Jan 22, 2024
| @@ -1022,11 +1022,6 @@ func (bc *BlockChain) SnapSyncCommitHead(hash common.Hash) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // StateAtWithSharedPool returns a new mutable state based on a particular point in time with sharedStorage | |||
| func (bc *BlockChain) StateAtWithSharedPool(root common.Hash) (*state.StateDB, error) { | |||
| return state.NewWithSharedPool(root, bc.stateCache, bc.snaps) | |||
There was a problem hiding this comment.
Does the NewWithSharedPool used in the InsertChain function need to be removed?
Line 2013 in f28b98a
There was a problem hiding this comment.
Does the
NewWithSharedPoolused in theInsertChainfunction need to be removed?Line 2013 in f28b98a
I am afraid not, InsertChain needs make sure backward compatibility, like the hertzFix case, so we can not remove the sharedPool logic from InsertChain
buddh0
approved these changes
Jan 22, 2024
unclezoro
approved these changes
Jan 22, 2024
fynnss
approved these changes
Jan 22, 2024
This was referenced Jan 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SharedPool was introduced since v1.1.9, but it has a potential bug and is no longer supported since hertzFix.
This PR is to remove the sharedPool code in miner module, which was introduced in this PR #818 and is useless now.
It has no impact to the current logic, but just code improve
Rationale
NA
Example
NA
Changes
NA