Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/ethapi: add optional parameter for blobSidecars #2467

Merged
merged 4 commits into from
May 16, 2024

Conversation

zlacfzy
Copy link
Contributor

@zlacfzy zlacfzy commented May 16, 2024

Description

Make the param showBlob optional, user don't need change the way to query blobs, even if they don't add the bool param it work as before.

Rationale

tell us why we need these changes...

Example

The two way both works now.

{"jsonrpc":"2.0","method":"eth_getBlobSidecars","params":["latest", false],"id":1}]'
{"jsonrpc":"2.0","method":"eth_getBlobSidecars","params":["latest"],"id":1}]'

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@zlacfzy zlacfzy changed the base branch from master to develop May 16, 2024 08:02
@zzzckck zzzckck merged commit 5edd032 into bnb-chain:develop May 16, 2024
7 checks passed
Copy link

@Zionsammy Zionsammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contracts/helpers/VerifierCaller.sol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants