fetcher: Sleep only after marking block as done when requeuing #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "miner/worker: broadcast block immediately once sealed (bnb-chain#2576)"
Draft release v1.4.13
Draft release v1.4.14
Otherwise the node will be waiting for 500ms before the block fetcher keeps processing.
buddh0
previously approved these changes
Sep 6, 2024
zzzckck
previously approved these changes
Sep 11, 2024
zzzckck
dismissed stale reviews from buddh0 and themself
The base branch was changed.
zzzckck
approved these changes
Sep 11, 2024
buddh0
approved these changes
Sep 11, 2024
This was referenced Sep 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requeuing a block (because of an unknown parent header), we should first mark the block as
donebefore sleeping for 500ms and retrying (requeuing). Otherwise, the block fetcher will wait for 500ms before continuing its process.