ethclient: move TransactionOpts to avoid import internal package; #2736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const MaxNumberOfEntries = 1000 | ||
|
|
||
| func (o *TransactionOpts) Check(blockNumber uint64, timeStamp uint64, statedb *state.StateDB) error { | ||
| func TxOptsCheck(o types.TransactionOpts, blockNumber uint64, timeStamp uint64, statedb *state.StateDB) error { |
There was a problem hiding this comment.
Why these Check functions also not transferred to the transaction_options.go?
There was a problem hiding this comment.
Oh, state.StateDB cannot transfer to low-level package types, so I leave these util functions here.
MatusKysel
reviewed
Oct 11, 2024
| ) | ||
|
|
||
| type AccountStorage struct { | ||
| StorageRoot *common.Hash |
There was a problem hiding this comment.
Suggested change
| StorageRoot *common.Hash | |
| StorageSlots map[common.Hash]*common.Hash |
Why not just a pointer
There was a problem hiding this comment.
I mean I know that code was just moved but maybe we could improve it
MatusKysel
approved these changes
Oct 11, 2024
|
TransactionOpts is only used by clients, |
|
zzzckck
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the issue #2722, developer cannot use
ethclient.SendTransactionConditionaldirectly that is caused by aimport error.Changes
Notable changes: