check length of signer addresses

bnb-chain · Mar 9, 2019 · 223787a · 223787a
1 parent 5618c72
commit 223787a
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/common/tx/ante.go b/common/tx/ante.go
@@ -205,9 +205,15 @@ func validateBasic(tx auth.StdTx) (err sdk.Error) {
 	}
 
 	// Assert that number of signatures is correct.
-	if signerAddrs := tx.GetSigners(); len(sigs) != len(signerAddrs) {
+	signerAddrs := tx.GetSigners()
+	if len(sigs) != len(signerAddrs) {
 		return sdk.ErrUnauthorized("wrong number of signers")
 	}
+	for _, signerAddr := range signerAddrs {
+		if len(signerAddr) != sdk.AddrLen {
+			return sdk.ErrInvalidAddress("contains invalid signer address")
+		}
+	}
 
 	if data := tx.GetData(); len(data) > 0 {
 		return sdk.ErrUnauthorized("data field is not allowed to use in transaction for now")