New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete recent price from db when delisting #753

Merged

EnderCrypto merged 5 commits into develop from fix_recent_price

Jun 22, 2020

Contributor

EnderCrypto commented Jun 17, 2020

Description

add a description of your changes here...

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

add each change in a bullet point here
...

Preflight checks

build passed (make build)
tests passed (make test)
integration tests passed (make integration_test)
manual transaction test passed (cli invoke)

Already reviewed by

...

Related issues

... reference related issue #'s here ...

EnderCrypto force-pushed the fix_recent_price branch from 538842d to d9e041a Compare

June 17, 2020 10:32


          delete recent price from db when delisting

f7bda47

EnderCrypto force-pushed the fix_recent_price branch from d9e041a to f7bda47 Compare

June 17, 2020 11:27

rickyyangz reviewed

View reviewed changes

plugins/dex/store/mapper.go Outdated

+              }
+              func removePrice(price []int64, i int) []int64 {
+              	return append(price[:i], price[i+1:]...)
+              }

Contributor

rickyyangz Jun 19, 2020 •

edited

Loading

I suggest giving the RecentPrice struct a method(like removePair) to remove both pair and price at the same time.

rickyyangz reviewed

View reviewed changes

plugins/dex/store/mapper.go Outdated

               	return recentPrices
               }
+              func (m mapper) DeleteRecentPrices(ctx sdk.Context, baseAsset, quoteAsset string) {

Contributor

rickyyangz Jun 19, 2020

just pass the trading symbol as the parameter

rickyyangz reviewed

View reviewed changes

plugins/dex/order/keeper.go Outdated

               	if err != nil {
               		kp.logger.Error("delete trading pair error", "err", err.Error())
               	}
+              	kp.PairMapper.DeleteRecentPrices(ctx, baseAsset, quoteAsset)

Contributor

rickyyangz Jun 19, 2020

better wrap a method to remove both from memory and db.

rickyyangz reviewed

View reviewed changes

plugins/dex/store/mapper_test.go Outdated

+              func TestMapper_DeleteRecentPrices(t *testing.T) {
+              	pairMapper, ctx := setup()
+              	for i := 0; i < 3000; i++ {

Contributor

rickyyangz Jun 19, 2020

can be much smaller if it is not a benchmark

rickyyangz reviewed

View reviewed changes

plugins/dex/store/mapper_test.go Outdated

+              	require.Equal(t, []interface{}{int64(10), int64(10), int64(10), int64(10), int64(10)}, allRecentPrices["ABC_BNB"].Elements())
+              	pairMapper.DeleteRecentPrices(ctx, "ABC", "BNB")
+              	allRecentPrices = pairMapper.GetRecentPrices(ctx, 2, 5)

Contributor

rickyyangz Jun 19, 2020

the parameters (ctx, 2, 5) are different from the above (ctx, 2, 10).
I suggest using a const instead.

rickyyangz reviewed

View reviewed changes

plugins/dex/store/mapper_test.go Outdated

+              		pairMapper.AddTradingPair(ctx, tradingPair)
+              	}
+              	for i := 0; i < 2000; i++ {

Contributor

rickyyangz Jun 19, 2020

I suggest using some const instead to make it more readable.


          refactor

db682e3

EnderCrypto force-pushed the fix_recent_price branch from 064d9d4 to db682e3 Compare

June 19, 2020 10:33

rickyyangz reviewed

View reviewed changes

plugins/dex/store/types.go Outdated

@@ @@ -35,3 +35,15 @@ type RecentPrice struct { @@
               	Pair  []string
               	Price []int64
               }
+              func (prices *RecentPrice) removeRecentPrice(symbolToDelete string) {

Contributor

rickyyangz Jun 19, 2020

maybe a little confusing about the name. "recentPrice.removeRecentPrice"

rickyyangz and others added 3 commits

June 22, 2020 11:33


          clean invalid recent prices before calculate lotsize

7ad0314


          Revert "clean invalid recent prices before calculate lotsize"

d73fff5

This reverts commit 7ad0314.


          change method name

6d930e6

rickyyangz approved these changes

View reviewed changes

rickyyangz reviewed

View reviewed changes

plugins/dex/store/mapper_test.go

+              	pairMapper, ctx := setup()
+              	for i := 0; i < 30; i++ {
+              		lastPrices := make(map[string]int64, pairNum)
+              		lastPrices["ABC_BNB"] = 10

Contributor

rickyyangz Jun 22, 2020

make some changes of the prices

EnderCrypto merged commit e21b91b into develop

EnderCrypto mentioned this pull request

0.7.2 Upgrade #756

Merged

4 tasks

unclezoro pushed a commit that referenced this pull request


          delete recent price from db when delisting (#753)

8e623e5

delete recent price from db when delisting

EnderCrypto added a commit that referenced this pull request


          0.7.2 Upgrade (#756)

56c4912

* delete recent price from db when delisting (#753)

delete recent price from db when delisting

* bump up version

* update changelog

* delete recent price key when recent price map is empty (#760)

* Force match all BEP2 symbols on BEP8 upgrade height to update last ma… (#758)

 Force match all BEP2 symbols on BEP8 upgrade height to update last match height

* Fix mini msg (#762)

* fix unfreeze err msg; adjust mini issue/list fee; update changelog

unclezoro pushed a commit that referenced this pull request


          delete recent price from db when delisting (#753)

1aa1e76

delete recent price from db when delisting

unclezoro deleted the fix_recent_price branch

May 10, 2022 06:11

forcodedancing pushed a commit that referenced this pull request


          0.7.2 Upgrade (#756)

5df8846

* delete recent price from db when delisting (#753)

delete recent price from db when delisting

* bump up version

* update changelog

* delete recent price key when recent price map is empty (#760)

* Force match all BEP2 symbols on BEP8 upgrade height to update last ma… (#758)

 Force match all BEP2 symbols on BEP8 upgrade height to update last match height

* Fix mini msg (#762)

* fix unfreeze err msg; adjust mini issue/list fee; update changelog

forcodedancing pushed a commit that referenced this pull request


          delete recent price from db when delisting (#753)

56bc904

delete recent price from db when delisting

forcodedancing pushed a commit that referenced this pull request


          0.7.2 Upgrade (#756)

e72fa70

* delete recent price from db when delisting (#753)

delete recent price from db when delisting

* bump up version

* update changelog

* delete recent price key when recent price map is empty (#760)

* Force match all BEP2 symbols on BEP8 upgrade height to update last ma… (#758)

 Force match all BEP2 symbols on BEP8 upgrade height to update last match height

* Fix mini msg (#762)

* fix unfreeze err msg; adjust mini issue/list fee; update changelog

forcodedancing pushed a commit that referenced this pull request


          delete recent price from db when delisting (#753)

90c89df

delete recent price from db when delisting

forcodedancing pushed a commit that referenced this pull request


          0.7.2 Upgrade (#756)

171fa63

* delete recent price from db when delisting (#753)

delete recent price from db when delisting

* bump up version

* update changelog

* delete recent price key when recent price map is empty (#760)

* Force match all BEP2 symbols on BEP8 upgrade height to update last ma… (#758)

 Force match all BEP2 symbols on BEP8 upgrade height to update last match height

* Fix mini msg (#762)

* fix unfreeze err msg; adjust mini issue/list fee; update changelog

forcodedancing pushed a commit that referenced this pull request


          delete recent price from db when delisting (#753)

8ba8bd5

delete recent price from db when delisting

forcodedancing pushed a commit that referenced this pull request


          0.7.2 Upgrade (#756)

5dd2331

* delete recent price from db when delisting (#753)

delete recent price from db when delisting

* bump up version

* update changelog

* delete recent price key when recent price map is empty (#760)

* Force match all BEP2 symbols on BEP8 upgrade height to update last ma… (#758)

 Force match all BEP2 symbols on BEP8 upgrade height to update last match height

* Fix mini msg (#762)

* fix unfreeze err msg; adjust mini issue/list fee; update changelog

forcodedancing pushed a commit that referenced this pull request


          delete recent price from db when delisting (#753)

d03fd2d

delete recent price from db when delisting

forcodedancing pushed a commit that referenced this pull request


          0.7.2 Upgrade (#756)

832b074

* delete recent price from db when delisting (#753)

delete recent price from db when delisting

* bump up version

* update changelog

* delete recent price key when recent price map is empty (#760)

* Force match all BEP2 symbols on BEP8 upgrade height to update last ma… (#758)

 Force match all BEP2 symbols on BEP8 upgrade height to update last match height

* Fix mini msg (#762)

* fix unfreeze err msg; adjust mini issue/list fee; update changelog

forcodedancing pushed a commit that referenced this pull request


          delete recent price from db when delisting (#753)

18a2bff

delete recent price from db when delisting

forcodedancing pushed a commit that referenced this pull request


          0.7.2 Upgrade (#756)

737722b

* delete recent price from db when delisting (#753)

delete recent price from db when delisting

* bump up version

* update changelog

* delete recent price key when recent price map is empty (#760)

* Force match all BEP2 symbols on BEP8 upgrade height to update last ma… (#758)

 Force match all BEP2 symbols on BEP8 upgrade height to update last match height

* Fix mini msg (#762)

* fix unfreeze err msg; adjust mini issue/list fee; update changelog

forcodedancing pushed a commit that referenced this pull request


          delete recent price from db when delisting (#753)

602a999

delete recent price from db when delisting

forcodedancing pushed a commit that referenced this pull request


          0.7.2 Upgrade (#756)

* delete recent price from db when delisting (#753)

delete recent price from db when delisting

* bump up version

* update changelog

* delete recent price key when recent price map is empty (#760)

* Force match all BEP2 symbols on BEP8 upgrade height to update last ma… (#758)

 Force match all BEP2 symbols on BEP8 upgrade height to update last match height

* Fix mini msg (#762)

* fix unfreeze err msg; adjust mini issue/list fee; update changelog

forcodedancing pushed a commit that referenced this pull request


          delete recent price from db when delisting (#753)

8eaf0f0

delete recent price from db when delisting

forcodedancing pushed a commit that referenced this pull request


          0.7.2 Upgrade (#756)

41f9de7

* delete recent price from db when delisting (#753)

delete recent price from db when delisting

* bump up version

* update changelog

* delete recent price key when recent price map is empty (#760)

* Force match all BEP2 symbols on BEP8 upgrade height to update last ma… (#758)

 Force match all BEP2 symbols on BEP8 upgrade height to update last match height

* Fix mini msg (#762)

* fix unfreeze err msg; adjust mini issue/list fee; update changelog

forcodedancing pushed a commit that referenced this pull request


          delete recent price from db when delisting (#753)

1d2d978

delete recent price from db when delisting

forcodedancing pushed a commit that referenced this pull request


          0.7.2 Upgrade (#756)

45c2e84

* delete recent price from db when delisting (#753)

delete recent price from db when delisting

* bump up version

* update changelog

* delete recent price key when recent price map is empty (#760)

* Force match all BEP2 symbols on BEP8 upgrade height to update last ma… (#758)

 Force match all BEP2 symbols on BEP8 upgrade height to update last match height

* Fix mini msg (#762)

* fix unfreeze err msg; adjust mini issue/list fee; update changelog

forcodedancing pushed a commit that referenced this pull request


          delete recent price from db when delisting (#753)

d091223

delete recent price from db when delisting

forcodedancing pushed a commit that referenced this pull request


          0.7.2 Upgrade (#756)

acb4619

* delete recent price from db when delisting (#753)

delete recent price from db when delisting

* bump up version

* update changelog

* delete recent price key when recent price map is empty (#760)

* Force match all BEP2 symbols on BEP8 upgrade height to update last ma… (#758)

 Force match all BEP2 symbols on BEP8 upgrade height to update last match height

* Fix mini msg (#762)

* fix unfreeze err msg; adjust mini issue/list fee; update changelog

forcodedancing pushed a commit that referenced this pull request


          delete recent price from db when delisting (#753)

cadf6b6

delete recent price from db when delisting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet