change the symbol minimum length to 2 #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fletcher142
requested review from
rickyyangz,
EnderCrypto and
forcodedancing
rickyyangz
reviewed
Dec 29, 2020
app/config/config.go
Outdated
| @@ -67,6 +67,8 @@ ListingRuleUpgradeHeight = {{ .UpgradeConfig.ListingRuleUpgradeHeight }} | |||
| FixZeroBalanceHeight = {{ .UpgradeConfig.FixZeroBalanceHeight }} | |||
| # Block height of smart chain upgrade | |||
| LaunchBscUpgradeHeight = {{ .UpgradeConfig.LaunchBscUpgradeHeight }} | |||
| # Block height of token length adjustment upgrade | |||
| AdjustTokenSymbolLengthHeight = {{ .UpgradeConfig.AdjustTokenSymbolLengthHeight }} | |||
There was a problem hiding this comment.
should be put in the right place
rickyyangz
reviewed
Dec 29, 2020
app/config/config.go
Outdated
| @@ -487,7 +489,8 @@ type UpgradeConfig struct { | |||
| ListingRuleUpgradeHeight int64 `mapstructure:"ListingRuleUpgradeHeight"` | |||
| FixZeroBalanceHeight int64 `mapstructure:"FixZeroBalanceHeight"` | |||
| // TODO: add upgrade name | |||
| LaunchBscUpgradeHeight int64 `mapstructure:"LaunchBscUpgradeHeight"` | |||
| LaunchBscUpgradeHeight int64 `mapstructure:"LaunchBscUpgradeHeight"` | |||
| AdjustTokenSymbolLengthHeight int64 `mapstructure:"AdjustTokenSymbolLengthHeight"` | |||
EnderCrypto
approved these changes
Dec 29, 2020
rickyyangz
approved these changes
Dec 30, 2020
|
Note: 1. sdk change 2. issue token page change |
unclezoro
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add a description of your changes here...
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes:
Preflight checks
make build)make test)make integration_test)Already reviewed by
...
Related issues
... reference related issue #'s here ...