Crypto-level random #839
Merged
Crypto-level random #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinglin89
force-pushed
the
ar-220215-01
branch
from
405fa1c
to
223b9e6
Compare
admin/client.go
Outdated
| rand.Seed(time.Now().UnixNano()) | ||
| nonce := strconv.Itoa(rand.Int()) | ||
| nTmp, _ := rand.Int(rand.Reader, big.NewInt(randMax)) | ||
| nonce := nTmp.Bytes() |
There was a problem hiding this comment.
Do we need to handle the error? If there is an error, will nTmp be nil?
Can we change nTmp to a more meaningful name?
There was a problem hiding this comment.
- Yes, it may fail due to a variety of reasons, will return error message to cli.
- Sure
forcodedancing
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
math/rand is the fastest for applications that don’t need crypto-level or security-related random data generation. crypto.rand is suited for secure and crypto-ready usage, but it’s slower. In the admin cli, the random number has been used on the nonce generation.
Rationale
Replace math.rand with crypto.rand which generate random integer within 0~2147483647
Changes
Notable changes: