Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy todo comments #845

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Tidy todo comments #845

merged 1 commit into from
Mar 3, 2022

Conversation

qinglin89
Copy link
Contributor

Description

There're quite a lot todo comments, should get rid of them.

Rationale

Screen out todos security/feature related for furthur development, and remove those which are useless.

Changes

Notable changes:

  • Remove some todo comments.

@qinglin89 qinglin89 changed the base branch from develop to pre-opensource March 2, 2022 02:51
@qinglin89 qinglin89 merged commit 198c97f into pre-opensource Mar 3, 2022
@forcodedancing forcodedancing mentioned this pull request Apr 20, 2022
Merged
@forcodedancing forcodedancing mentioned this pull request Apr 28, 2022
Merged
@unclezoro unclezoro deleted the tidytodo branch May 10, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forcodedancing forcodedancing forcodedancing approved these changes

@unclezoro unclezoro Awaiting requested review from unclezoro

@yutianwu yutianwu Awaiting requested review from yutianwu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qinglin89 @forcodedancing