fix: add bsc chainID to encodeSigHeader when submitting evidence for slashing #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randyahx
force-pushed
the
randyahx/bsc-encodesigheader
branch
from
4402ff5
to
6ff3366
Compare
unclezoro
approved these changes
Dec 21, 2022
j75689
approved these changes
Dec 21, 2022
unclezoro
changed the title
This was referenced Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to prevent malicious behaviour from the validators, slashing has to be implemented as a counter measure. However, a bug in the current implementation is preventing the slashing mechanism from working as intended. Until this is fixed, validators cannot be punished for double signing a block.
Specification
In BSC sealHash is calculated taking into account Chain ID. However encodeSigHeader does not take into account chainID, meaning that sealHash will return an incorrect hash, thus ExtractSignerFromHeader() returns an invalid signer. In BSC header hash is Sealed including chainID, so encodeSigHeader() must include the chain ID.