feat: limit sidechain consensus addr update interval #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
approved these changes
Feb 1, 2023
forcodedancing
approved these changes
Feb 1, 2023
forcodedancing
pushed a commit
to forcodedancing/node
that referenced
this pull request
Feb 8, 2023
This was referenced Feb 8, 2023
unclezoro
pushed a commit
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sidechain consensus address modification is introduced in BEP159, which enables the sidechain validators to change their consensus address.
The proposer choice in BSC is related to the consensus address. There is a chance that a validator may improve the possibility to be chosen by changing the consensus address. So the update interval is limited to be changed once a month.
This PR adds the hardfork setting and an integration test.
related PR: bnb-chain/bnc-cosmos-sdk#318