Add support for named groups #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
force-pushed
the
named-groups
branch
from
a91e3d3
to
bbf80ca
Compare
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 88.88% 88.88%
=======================================
Files 1 1
Lines 189 198 +9
Branches 57 60 +3
=======================================
+ Hits 168 176 +8
- Misses 21 22 +1
Continue to review full report at Codecov.
|
|
Thanks for the PR, will look at it and merge in a while! |
bnjmnt4n
added a commit
that referenced
this pull request
Jan 17, 2018
Add support for named groups.
|
Bumped v0.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🙂
regjsparser pr: jviereck/regjsparser#83