Skip to content

Commit

Permalink
deps: cherry-pick b767cde1e7 from upstream V8
Browse files Browse the repository at this point in the history
Original commit message:

    [intl] unbreak build with ICU 57

    Remove a call to `icu::toUCharPtr()` that wasn't present in other
    similar looking call sites either, just reinterpret_cast directly.

    Fixes nodejs#19656.

    Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
    Change-Id: If281ce0a39356aa8bd20efb24c3e4b52b06841a3
    Reviewed-on: https://chromium-review.googlesource.com/987953
    Reviewed-by: Daniel Ehrenberg <[email protected]>
    Commit-Queue: Ben Noordhuis <[email protected]>
    Cr-Commit-Position: refs/heads/master@{nodejs#52311}

Fixes: nodejs#19656
  • Loading branch information
bnoordhuis committed Mar 31, 2018
1 parent 0d64f33 commit 772393c
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions deps/v8/src/runtime/runtime-intl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -626,8 +626,7 @@ RUNTIME_FUNCTION(Runtime_PluralRulesSelect) {
icu::UnicodeString result = plural_rules->select(rounded);
return *isolate->factory()
->NewStringFromTwoByte(Vector<const uint16_t>(
reinterpret_cast<const uint16_t*>(
icu::toUCharPtr(result.getBuffer())),
reinterpret_cast<const uint16_t*>(result.getBuffer()),
result.length()))
.ToHandleChecked();
}
Expand Down

0 comments on commit 772393c

Please sign in to comment.