Skip to content

Commit

Permalink
test: make flaky pummel test more reliable
Browse files Browse the repository at this point in the history
Increase the number of iterations from 1e4 to 1e5.  Makes the test pass
for me locally when previously it would fail 9 out of 10 times because
the running time was not enough to smooth away the outliers.

Fixes: nodejs#8744
PR-URL: nodejs#9241
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: not-an-aardvark <[email protected]>
  • Loading branch information
bnoordhuis committed Oct 24, 2016
1 parent 1b8fca1 commit d1f7c96
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/pummel/test-crypto-timing-safe-equal-benchmarks.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function runOneBenchmark(...args) {
}

function getTValue(compareFunc) {
const numTrials = 10000;
const numTrials = 1e5;
const bufSize = 10000;
// Perform benchmarks to verify that timingSafeEqual is actually timing-safe.

Expand Down

0 comments on commit d1f7c96

Please sign in to comment.