Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement for loop execution #365

Closed
Razican opened this issue May 2, 2020 · 2 comments · Fixed by #374
Closed

Implement for loop execution #365

Razican opened this issue May 2, 2020 · 2 comments · Fixed by #374
Assignees
@akryvomaz
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v0.8.0

Comments

@Razican
Copy link
Member

Razican commented May 2, 2020

The parser generates Node::ForLoop when it encounters a for loop, but this is not implemented in the executor, so it panics.

This can be implemented by adding another match arm to the run() function in the exec/mod.rs file.
@Razican Razican added enhancement New feature or request good first issue Good for newcomers labels May 2, 2020
@Razican Razican mentioned this issue May 2, 2020
Closed
@akryvomaz
Copy link
Contributor

akryvomaz commented May 6, 2020 •
edited
Loading

Hi, I'd like to implement it

@Razican
Copy link
Member Author

Razican commented May 6, 2020

Hi, I'd like to implement it

Sure! Let us know if you need any mentoring :)

@akryvomaz akryvomaz mentioned this issue May 6, 2020
Merged
@Razican Razican added this to the v0.8.0 milestone May 7, 2020
@Razican Razican linked a pull request May 7, 2020 that will close this issue
Implement for loop #374
Merged
@Razican Razican closed this as completed May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akryvomaz akryvomaz

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

Implement for loop akryvomaz/boa
2 participants
@Razican @akryvomaz