-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement for loop #374
Implement for loop #374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks real good! Thanks for your contribution. I am missing tests for the initialization and the step though, could you add them?
@Razican do you mean something like this for initialization test?
Do you have an idea for a good step test? |
Something we could do for both would be something like this: let a = "hello";
let b = '';
for (var i = 0; i < a.length; i = i + 1) {
b = b + a[i];
}
b; Which should equal to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go for me!
#365