You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The test just checks if the prototype of the instance is an object using the is_object method.
Consider the following js snippet (similar to the example in the test):
functionFoo(){}varbar=newFoo();
The test currently asserts typeof bar.__proto__ === "object"
Rather it should assert bar.__proto__ === Foo.prototype.
I guess the point of the test was to just check if bar.__proto__ was an object. But it's good to go one step further to assert that the prototype is correctly assigned to be Foo.prototype
The text was updated successfully, but these errors were encountered:
Describe the bug
The test just checks if the prototype of the instance is an object using the
is_object
method.Consider the following js snippet (similar to the example in the test):
The test currently asserts
typeof bar.__proto__ === "object"
Rather it should assert
bar.__proto__ === Foo.prototype
.I guess the point of the test was to just check if
bar.__proto__
was an object. But it's good to go one step further to assert that the prototype is correctly assigned to beFoo.prototype
The text was updated successfully, but these errors were encountered: