Fix 532, 533, 641 #642
Merged
Fix 532, 533, 641 #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #642 +/- ##
==========================================
+ Coverage 72.64% 72.67% +0.02%
==========================================
Files 179 179
Lines 13275 13279 +4
==========================================
+ Hits 9644 9650 +6
+ Misses 3631 3629 -2
Continue to review full report at Codecov.
|
This was
linked to
issues
Aug 18, 2020
Razican
added
bug
Razican
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
Thanks for the contribution!
I'm not an expert on how this should work, so I leave that for @jasonwilliams, @HalidOdat and @Lan2u.
From my side, the code looks perfect :)
HalidOdat
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes #532, #533, & #641.