Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined constants panic on execution #644

Closed
Razican opened this issue Aug 19, 2020 · 0 comments · Fixed by #645
Closed

undefined constants panic on execution #644

Razican opened this issue Aug 19, 2020 · 0 comments · Fixed by #645
Labels
bug Something isn't working execution Issues or PRs related to code execution good first issue Good for newcomers
Milestone

Comments

@Razican
Copy link
Member

Razican commented Aug 19, 2020

The following code panics when being run:

let a = undefined;

This is because we have not implemented the execution of undefined here. The solution is simple enough as a good first issue:

You will need to add a match arm, that converts a Node::Const(Const::Undefined) to an Ok(Value::Undefined).

This could also be related to #631.

@Razican Razican added bug Something isn't working good first issue Good for newcomers execution Issues or PRs related to code execution labels Aug 19, 2020
@Razican Razican added this to the v0.10.0 milestone Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant