Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined constant expression evaluation #645

Merged
merged 3 commits into from
Aug 19, 2020
Merged

Fix undefined constant expression evaluation #645

merged 3 commits into from
Aug 19, 2020

Conversation

jcdickinson
Copy link
Contributor

This Pull Request fixes/closes #644 and #631.

It changes the following:

  • Adds support for undefined expr
  • Makes the Node match exhaustive (I have ConditionalOp and Continue as a local WIP, but they don't really belong in this PR)

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #645 into master will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #645   +/-   ##
=======================================
  Coverage   72.94%   72.95%           
=======================================
  Files         178      178           
  Lines       13234    13240    +6     
=======================================
+ Hits         9654     9659    +5     
- Misses       3580     3581    +1     
Impacted Files Coverage Δ
boa/src/exec/mod.rs 70.80% <0.00%> (-0.45%) ⬇️
boa/src/exec/tests.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a51530...25c8fe2. Read the comment docs.

@Razican Razican added bug Something isn't working execution Issues or PRs related to code execution labels Aug 19, 2020
@Razican Razican added this to the v0.10.0 milestone Aug 19, 2020
@Razican Razican linked an issue Aug 19, 2020 that may be closed by this pull request
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good from my side :)

@HalidOdat HalidOdat merged commit 13f7374 into boa-dev:master Aug 19, 2020
@jcdickinson jcdickinson deleted the issue644 branch August 19, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undefined constants panic on execution Unexpected result when applying typeof to undefined value
3 participants