-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(boa): implements at
method for string
#1375
Conversation
Test262 conformance changes:
Fixed tests:
|
Note that this doesn't close #13, since there are more methods left to implement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me. Check my comments. Note that this is a "proposal", and therefore not part of #13, and no other JS engine is implementing it. I want to know what @jasonwilliams thinks about adding these things to Boa.
I mainly added it thinking it was failing the test262 suite, but I see what you mean. |
Since it is in test262, its probably going to be added to the language eventualy, but maybe we should wait till then. |
Its ok with me, I don't mind seeing proposals like this one being added as its quite likely to make it in |
This Pull Request relates to #13.
It changes the following: