array: implement array.slice #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
letmutx
suggested changes
Oct 22, 2019
src/lib/js/array.rs
Outdated
| /// length is the length of the array. | ||
| /// <https://tc39.es/ecma262/#sec-array.prototype.slice> | ||
| pub fn slice(this: &Value, args: &[Value], interpreter: &mut Interpreter) -> ResultValue { | ||
| let new_array = make_array(&to_value(Object::default()), &[], interpreter)?; |
There was a problem hiding this comment.
After creating an object, you need to mark it as an array and set it's prototype. Check here for sample code on how to do it.
src/lib/js/array.rs
Outdated
|
|
||
| let start = match args.get(0) { | ||
| Some(v) => from_value(v.clone()).expect("failed to parse argument for Array method"), | ||
| None => return Ok(this.clone()), |
There was a problem hiding this comment.
Should be returning the new array here. this.clone() will only copy the reference. Test case:
var animals = ['ant', 'bison', 'camel', 'duck', 'elephant'];
var animals2 = animals.splice();
animals.push(5);
console.log(animals, animals2);
> Array ["ant", "bison", "camel", "duck", "elephant", 5] Array []
src/lib/js/array.rs
Outdated
|
|
||
| let span = max(to.wrapping_sub(from), 0); | ||
| for i in from..from.wrapping_add(span) { | ||
| add_to_array_object(&new_array, &[this.get_field(&i.to_string())])?; |
There was a problem hiding this comment.
I think it's better to just call this.set_field rather than constructing a slice and calling add_to_array_object.
There was a problem hiding this comment.
@muskuloes Sorry, not this.set_field but new_array.set_field
jasonwilliams
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
array.slice per #177