Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added examples #3141

Merged
merged 3 commits into from
Aug 6, 2023
Merged

Added examples #3141

merged 3 commits into from
Aug 6, 2023

Conversation

postmeback
Copy link
Contributor

@postmeback postmeback commented Jul 15, 2023

This Pull Request fixes/closes #2337

It changes the following:

Added two new functions to test Interner::default(); & Interner::with_capacity;

Requesting for review

@postmeback
Copy link
Contributor Author

Hey, Can this be added ?

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #3141 (7c176e6) into main (b51e7cf) will decrease coverage by 0.19%.
Report is 52 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3141      +/-   ##
==========================================
- Coverage   50.62%   50.43%   -0.19%     
==========================================
  Files         444      436       -8     
  Lines       42692    42531     -161     
==========================================
- Hits        21612    21450     -162     
- Misses      21080    21081       +1     

see 99 files with indirect coverage changes

@postmeback
Copy link
Contributor Author

Can anyone tell me, how to fix this rustfmt error?

@Razican
Copy link
Member

Razican commented Aug 6, 2023

Can anyone tell me, how to fix this rustfmt error?

You will need to run cargo fmt with the latest Rust stable.

@postmeback
Copy link
Contributor Author

image

@postmeback
Copy link
Contributor Author

Changed as per the lint suggestion

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jedel1043 jedel1043 added this pull request to the merge queue Aug 6, 2023
Merged via the queue into boa-dev:main with commit ca969d6 Aug 6, 2023
9 checks passed
@postmeback
Copy link
Contributor Author

Thanks @Razican , @jedel1043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add code examples for boa_interner
3 participants