Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Monaco Editor Webpack Plugin and Manually Vendor Editor Workers #362

Merged
merged 3 commits into from
May 13, 2020

Conversation

subhankar-panda
Copy link
Contributor

Follows the "manual approach" listed here.

Fixes #314.

The issue with #355 was that it was never able to find the ts worker - this manually tells webpack where to look for the files

@jasonwilliams
Copy link
Member

Hey @subhankar-panda thanks for this!
Do you know if there's anything we can do about getting rid of all the language-support we don't need.

When you run yarn build then look in dist folder it generates a lot of js files, for all the different syntaxes it supports, is there a way to just have javascript?

@Razican Razican added the bug Something isn't working label May 5, 2020
@Razican Razican added this to the v0.8.0 milestone May 7, 2020
@jasonwilliams jasonwilliams merged commit fefb5a3 into boa-dev:master May 13, 2020
@Razican Razican mentioned this pull request May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Live demo has console errors in browser (monaco editor)
3 participants