Add support for the reviver function to JSON.parse #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! This will collide with #402, though. We should probably wait for that to land. |
|
@Razican Sure! Meanwhile, can you please take a look at the changes? |
Yep, I will check this today :) |
HalidOdat
reviewed
May 22, 2020
|
The next thing we need to do is adding tests, so we insure it does not break in the future. |
|
Yes, working on it. |
|
@Razican @HalidOdat review? |
HalidOdat
reviewed
May 31, 2020
|
@HalidOdat review? |
HalidOdat
approved these changes
May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request tries to fix #344.
This PR needs lots of changes to the way we extract object while recursing. I tried using
matchon theValueusingas_object()but this results in a borrow problem since i am passing a&mut Valuetowalk. So at the moment, i am cloning the unwrapped object after checking if it is safe to do so.Need feedback on that.