Number constants #420
Number constants #420
Conversation
Co-authored-by: HalidOdat <[email protected]>
Co-authored-by: HalidOdat <[email protected]>
Thanks for the help, changes made :) With regards to Number.NaN vs Number.NAN is this something which should be looked at as part of this or separately? (unless I've made a mistake of course). |
About this, it should be treated separately, it would require changes to the lexer and parser. For now you can comment it out and add a |
HalidOdat
added
builtins
boa/src/builtins/number/mod.rs
Outdated
| // Constants from: | ||
| // Draft ECMA-262 / May 22, 2020 ECMAScript® 2021 Language Specification | ||
| // Section 20.1.2 Properties of the Number Constructor |
boa/src/builtins/number/mod.rs
Outdated
| number.set_field("POSITIVE_INFINITY", Value::from(f64::INFINITY)); | ||
|
|
||
| // TODO: Currently parsing/lexing Number.NaN is not supported due to the inclusion of the lower case 'a'. | ||
| // number.set_field("NaN", Value::from(f64::NAN)); |
There was a problem hiding this comment.
I would still add this here, so that when we fix the lexer this will just work. What do you think, @HalidOdat?
There was a problem hiding this comment.
I would still add this here, so that when we fix the lexer this will just work. What do you think, @HalidOdat?
Yep. We could add it! That's probably the best option.
Edit: we might be able to access it with Number["NaN"]
There was a problem hiding this comment.
I created #421 related to this.
This Pull Request fixes #414 .
It changes the following:
The constant NaN is expressed currently as NAN because using the lowercase a was causing the parser to interpret it as an identifier not a constant.