Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use a newer version of codecov github action #436

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Update to use a newer version of codecov github action #436

merged 1 commit into from
Jun 1, 2020

Conversation

Lan2u
Copy link

@Lan2u Lan2u commented Jun 1, 2020

Relates to issue #378.

It changes the following:

  • Updated codecov action version specified to 1.0.7 (latest version) to try and see if this fixes the problem with tokenless codecov not working.

@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@640b76e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #436   +/-   ##
=========================================
  Coverage          ?   66.72%           
=========================================
  Files             ?      123           
  Lines             ?     8809           
  Branches          ?        0           
=========================================
  Hits              ?     5878           
  Misses            ?     2931           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 640b76e...eb493f1. Read the comment docs.

@Lan2u
Copy link
Author

Lan2u commented Jun 1, 2020

Seems to be working, https://codecov.io/github/boa-dev/boa/commit/eb493f14a8095bcc38d9c5ce8b107db30c4d2783.

@HalidOdat HalidOdat added the bug Something isn't working label Jun 1, 2020
@HalidOdat HalidOdat added this to the v0.9.0 milestone Jun 1, 2020
@jasonwilliams
Copy link
Member

1.0.6 fixed this:
Add tokenless upload functionality by passing the GITHUB_RUN_ID environment variable to properly tag the build. This allows Codecov to locate the build via GitHub's API and validate the coverage upload

@jasonwilliams jasonwilliams merged commit b308f82 into boa-dev:master Jun 1, 2020
@Lan2u Lan2u deleted the patch-1 branch June 1, 2020 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants