Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise type comparisons #441

Merged
merged 58 commits into from
Jun 10, 2020
Merged

Optimise type comparisons #441

merged 58 commits into from
Jun 10, 2020

Conversation

Lan2u
Copy link

@Lan2u Lan2u commented Jun 1, 2020 •
edited
Loading

This Pull Request fixes #435.

It changes the following:

  • Add a new Type enum which is returned from the get_type() function replacing the string used previously.
  • Updates usages.

I've made the mistake of basing this of the branch used for pull request #422 so depending on if/when that PR is merged this PR can be merged. If it's going to be a pain to merge I can re-do it based on master.

Paul Lancaster and others added 30 commits May 26, 2020 09:04
Merge pull request #4 from boa-dev/master
c4fb91c 
Catchup
Adding Object Execution trait
7ffc0c8
Moved Object AST related parts into their own files
57fa83d
Rustfmt
88a5ba3
Make clippy happier
e51d8be
Starting to reimplement switch
4c058c0
@Razican
Remove extra newline
744dee8 
Co-authored-by: Iban Eguia <[email protected]>
Replaced AST object new with From
dc6b371
Merge branch 'divide_run' of https://github.com/Lan2u/boa into divide…
8995fb2 
…_run
Rustfmt
d91ac61
Merge pull request #5 from Lan2u/divide_run
274910a 
Catchup
Starting to move switch AST into seperate files
4b0bed1
Seperated switch AST node into seperate files
8ff5590
Merge: Seperated switch AST node into seperate files
d0e82b5 
Switch part divided up from run
Started moving GetConstField related parts into own file
6851036
Correcting various references to Node::GetConstField to use new signa…
153f0b1 
…ture
Extracted GetField code
c0404f3
Fmt, clippy
e33a1a5
Merge pull request #7 from Lan2u/divide_run_get_const_field
9969748 
Divided up GetConstField, GetField
WhileLoop
4937dc3 
seperated out
Impl fmt::display for WhileLoop
ad07527
DoWhileLoop struct created
be04070
Seperated out do while loop
58f83f7
Merge pull request #8 from Lan2u/divide_run_dowhile
26fdf9d 
Divide run dowhile
Created Return struct
13daec1
Seperated Return statement out
2116152
Seperated IF statement out
cc7261a
Removed unused imports, fmt
c858a79
Created Break struct
b5ca4b8
Break impl
94dcacc
HalidOdat
HalidOdat reviewed Jun 1, 2020
View reviewed changes
boa/src/builtins/value/val_type.rs Outdated Show resolved Hide resolved
boa/src/builtins/value/val_type.rs Outdated Show resolved Hide resolved
boa/src/builtins/value/mod.rs Outdated Show resolved Hide resolved
@Lan2u Lan2u marked this pull request as ready for review June 3, 2020 20:16
@Razican Razican added blocked Waiting for another code change enhancement New feature or request labels Jun 6, 2020
@Razican Razican added this to the v0.9.0 milestone Jun 6, 2020
Razican
Razican reviewed Jun 6, 2020
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking pretty good. Let's wait for #422 to land to be able to easily see the changes in this branch.

boa/src/exec/conditional/mod.rs Outdated Show resolved Hide resolved
@Razican Razican added builtins PRs and Issues related to builtins/intrinsics execution Issues or PRs related to code execution labels Jun 6, 2020
Razican
Razican approved these changes Jun 7, 2020
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool this is good to go then!

@HalidOdat HalidOdat removed the blocked Waiting for another code change label Jun 10, 2020
HalidOdat
HalidOdat approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect to me! Just needs a rebase :)

@Razican Razican merged commit 634dfb7 into boa-dev:master Jun 10, 2020
@Lan2u Lan2u deleted the optimise_type_comparisons branch June 10, 2020 10:31
@RageKnify RageKnify mentioned this pull request Oct 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request execution Issues or PRs related to code execution
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

Optimize type comparisons
3 participants
@Lan2u @Razican @HalidOdat