Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed global objects initialization order #502

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Conversation

HalidOdat
Copy link
Member

It changes the following:

  • Fix the order of builtins (Object should be initialized before Array)
  • Removed vec![] from builtins

This unblocks #434

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Jun 17, 2020
@HalidOdat HalidOdat added this to the v0.9.0 milestone Jun 17, 2020
@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #502 into master will decrease coverage by 0.18%.
The diff coverage is 24.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
- Coverage   67.67%   67.48%   -0.19%     
==========================================
  Files         162      162              
  Lines        9867     9869       +2     
==========================================
- Hits         6677     6660      -17     
- Misses       3190     3209      +19     
Impacted Files Coverage Δ
boa/src/builtins/mod.rs 26.92% <24.00%> (-73.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae939a...3e996e4. Read the comment docs.

@github-actions
Copy link

Benchmark for 9021bcf

Click to view benchmark
Test PR Benchmark Master Benchmark %
Array access (Execution) 25.6±0.97µs 26.9±3.46µs -4.83%
Array creation (Execution) 6.8±0.09ms 6.8±0.14ms 0.00%
Array pop (Execution) 2.4±0.05ms 2.5±0.10ms -4.00%
Boolean Object Access (Execution) 9.1±0.42µs 8.9±0.66µs +2.25%
Create Realm 181.0±3.86µs 189.2±6.54µs -4.33%
Dynamic Object Property Access (Execution) 11.8±0.77µs 12.3±0.96µs -4.07%
Expression (Lexer) 2.1±0.28µs 2.0±0.07µs +5.00%
Expression (Parser) 5.0±0.17µs 5.1±0.27µs -1.96%
Fibonacci (Execution) 1984.0±79.83µs 2.1±0.04ms -5.52%
For loop (Execution) 57.6±1.85µs 59.2±1.88µs -2.70%
For loop (Lexer) 5.3±0.30µs 5.4±0.61µs -1.85%
For loop (Parser) 13.5±0.64µs 13.5±0.20µs 0.00%
Hello World (Lexer) 923.9±21.25ns 913.7±31.48ns +1.12%
Hello World (Parser) 2.2±0.07µs 2.2±0.06µs 0.00%
Long file (Parser) 6.1±0.12ms 6.1±0.10ms 0.00%
Number Object Access (Execution) 7.3±0.24µs 6.9±0.39µs +5.80%
Object Creation (Execution) 10.5±0.34µs 10.7±0.24µs -1.87%
RegExp (Execution) 77.7±6.58µs 77.5±2.52µs +0.26%
RegExp Literal (Execution) 81.1±3.38µs 81.3±3.28µs -0.25%
RegExp Literal Creation (Execution) 73.2±4.32µs 78.1±3.23µs -6.27%
Static Object Property Access (Execution) 11.0±0.18µs 11.1±0.35µs -0.90%
String Object Access (Execution) 15.8±0.91µs 15.8±0.52µs 0.00%
String comparison (Execution) 11.0±0.36µs 11.1±0.35µs -0.90%
String concatenation (Execution) 9.2±0.26µs 8.9±0.45µs +3.37%
String copy (Execution) 7.6±0.30µs 7.1±0.52µs +7.04%
Symbols (Execution) 8.3±0.54µs 8.4±0.22µs -1.19%

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me :)

@HalidOdat HalidOdat merged commit e674da4 into master Jun 17, 2020
@HalidOdat HalidOdat deleted the fix/builtins-order branch June 17, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants