Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Update CHANGELOG.md for 0.9 #540

Closed
wants to merge 3 commits into from
Closed

[Minor] Update CHANGELOG.md for 0.9 #540

wants to merge 3 commits into from

Conversation

pedropaulosuzuki
Copy link
Contributor

Some of the updates were in the wrong place (benchmark on features instead of Internal #428, cleanup of Math methods #514 is a internal refactor more than a bug fix).

Some of the updates were in the wrong place (benchmark on features instead of Internal #428, cleanup of Math methods #514 is a internal refactor more than a bug fix).
@pedropaulosuzuki pedropaulosuzuki changed the title Update CHANGELOG.md for 0.9 [Minor] Update CHANGELOG.md for 0.9 Jul 2, 2020
@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #540 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #540      +/-   ##
==========================================
+ Coverage   68.09%   68.10%   +0.01%     
==========================================
  Files         169      169              
  Lines        9942     9942              
==========================================
+ Hits         6770     6771       +1     
+ Misses       3172     3171       -1     
Impacted Files Coverage Δ
boa/src/exec/break_node/mod.rs 100.00% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d1597...250272a. Read the comment docs.

CHANGELOG.md Outdated
@@ -12,6 +12,8 @@ Feature Enhancements:
Implement global `Infinity` property (@AnirudhKonduru)
- [FEATURE #410](https://github.com/boa-dev/boa/pull/410):
Add support for the reviver function to JSON.parse (@abhijeetbhagat)
- [FEATURE #525](https://github.com/boa-dev/boa/pull/425):
Implement additional `Math` methods (@mr-rodgers)
Copy link
Member

@jasonwilliams jasonwilliams Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you change this to mr-rodgers?
I don't see him on that PR (#514) which is also now wrong for this.
The descrition is Implement additional Mathmethods` but it links to #425

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, when I copy/pasted the [FEATURE #525], I forgot to update the link.

Didn't get the #514 part though, it is mentioned below in [Internal #514].

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#525 looks like its still open so shouldn't really be on here.
0.9.0 has been closed now, so any remaining PRs will go into 0.10.0

@HalidOdat HalidOdat added the documentation update documentation label Jul 2, 2020
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to merge #525 first

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: HalidOdat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation update documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants