Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Number methods. #562

Merged
merged 5 commits into from
Jul 13, 2020
Merged

Add missing Number methods. #562

merged 5 commits into from
Jul 13, 2020

Conversation

joshwd36
Copy link
Contributor

This Pull Request adds the missing Number and Global methods:

  • isFinite()
  • isNaN()
  • Number.isFinite()
  • Number.isInteger()
  • Number.isNaN()
  • Number.isSafeInteger()

@codecov
Copy link

codecov bot commented Jul 12, 2020 •
edited
Loading

Codecov Report

Merging #562 into master will increase coverage by 0.37%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #562      +/-   ##
==========================================
+ Coverage   69.30%   69.67%   +0.37%     
==========================================
  Files         172      172              
  Lines       10580    10740     +160     
==========================================
+ Hits         7332     7483     +151     
- Misses       3248     3257       +9
Impacted Files Coverage Δ
boa/src/builtins/number/mod.rs 67.65% <77.77%> (+2.03%) ⬆️
boa/src/builtins/number/tests.rs 100.00% <100.00%> (ø)
boa/src/builtins/value/operations.rs 30.87% <0.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffe8b5f...1f8e4f8. Read the comment docs.

HalidOdat
HalidOdat reviewed Jul 12, 2020
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! check my comments :)

boa/src/builtins/number/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/number/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/number/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/number/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/number/mod.rs Outdated Show resolved Hide resolved
@HalidOdat HalidOdat added builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request labels Jul 12, 2020
@HalidOdat HalidOdat added this to the v0.10.0 milestone Jul 12, 2020
HalidOdat
HalidOdat reviewed Jul 12, 2020
View reviewed changes
boa/src/builtins/number/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/number/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/number/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/number/tests.rs Show resolved Hide resolved
HalidOdat
HalidOdat reviewed Jul 13, 2020
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks almost ready to merge :)

boa/src/builtins/number/mod.rs Show resolved Hide resolved
HalidOdat
HalidOdat approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! :)

Razican
Razican approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@Razican Razican merged commit 690b194 into boa-dev:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

@Lan2u Lan2u Awaiting requested review from Lan2u

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@joshwd36 @Razican @HalidOdat