-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date Implementation #596
Date Implementation #596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review these changes (first commit), the Date
constructor can be called as a regular function and behaves differently. In order to do that, I need to determine if this
is global
(the spec calls this "thisTarget
is undefined
", but there is no thisTarget
in Boa).
Codecov Report
@@ Coverage Diff @@
## master #596 +/- ##
==========================================
+ Coverage 71.67% 72.51% +0.84%
==========================================
Files 177 179 +2
Lines 11647 12553 +906
==========================================
+ Hits 8348 9103 +755
- Misses 3299 3450 +151
Continue to review full report at Codecov.
|
Marking this as ready for review. This will likely need to be revisited when test262 works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, check my comments :)
This Pull Request fixes/closes #252.
It changes the following:
[Global]
internal slot that contains nothing. This is used to differentiate between constructor calls and function calls in theDate
constructor.Date
according to spec.