Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed internal_slots from object #601

Merged
merged 1 commit into from
Aug 1, 2020
Merged

Conversation

HalidOdat
Copy link
Member

It changes the following:

  • Removed internal slots

@HalidOdat HalidOdat added technical debt execution Issues or PRs related to code execution labels Jul 31, 2020
@HalidOdat HalidOdat added this to the v0.10.0 milestone Jul 31, 2020
@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #601 into master will increase coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
+ Coverage   71.23%   71.34%   +0.11%     
==========================================
  Files         177      177              
  Lines       11588    11563      -25     
==========================================
- Hits         8255     8250       -5     
+ Misses       3333     3313      -20     
Impacted Files Coverage Δ
boa/src/builtins/function/mod.rs 70.48% <ø> (-0.18%) ⬇️
boa/src/builtins/object/internal_methods.rs 29.51% <0.00%> (-0.66%) ⬇️
boa/src/builtins/object/mod.rs 39.17% <ø> (+0.84%) ⬆️
boa/src/builtins/value/mod.rs 65.92% <ø> (+2.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a3b69f...9e1cff1. Read the comment docs.

@github-actions
Copy link

Benchmark for 060e9ae

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 377.5±6.06ns 373.0±6.03ns +1.21%
Arithmetic operations (Full) 163.2±2.99µs 173.9±3.69µs -6.15%
Array access (Execution) 8.2±0.34µs 8.4±0.24µs -2.38%
Array access (Full) 178.7±5.11µs 187.6±5.10µs -4.74%
Array creation (Execution) 3.5±0.09ms 3.3±0.05ms +6.06%
Array creation (Full) 3.6±0.05ms 3.6±0.07ms 0.00%
Array pop (Execution) 1266.1±47.17µs 1183.2±36.76µs +7.01%
Array pop (Full) 1508.3±36.72µs 1499.0±27.13µs +0.62%
Boolean Object Access (Execution) 4.3±0.13µs 4.5±0.10µs -4.44%
Boolean Object Access (Full) 174.2±3.61µs 182.3±4.38µs -4.44%
Create Realm 435.6±8.46ns 473.1±7.13ns -7.93%
Dynamic Object Property Access (Execution) 4.8±0.34µs 5.3±0.14µs -9.43%
Dynamic Object Property Access (Full) 172.6±3.08µs 183.8±5.64µs -6.09%
Expression (Lexer) 2.4±0.07µs 2.4±0.06µs 0.00%
Expression (Parser) 5.5±0.11µs 5.5±0.06µs 0.00%
Fibonacci (Execution) 877.9±17.67µs 948.3±17.06µs -7.42%
Fibonacci (Full) 1062.1±38.98µs 1157.0±52.30µs -8.20%
For loop (Execution) 21.7±0.43µs 21.8±0.62µs -0.46%
For loop (Full) 195.4±14.55µs 200.5±4.94µs -2.54%
For loop (Lexer) 5.3±0.09µs 5.3±0.17µs 0.00%
For loop (Parser) 13.7±0.30µs 14.3±0.36µs -4.20%
Goal Symbols (Parser) 8.3±0.33µs 8.8±1.01µs -5.68%
Hello World (Lexer) 821.6±16.15ns 835.8±18.65ns -1.70%
Hello World (Parser) 2.2±0.04µs 2.2±0.10µs 0.00%
Long file (Parser) 6.1±0.12ms 6.4±0.07ms -4.69%
Number Object Access (Execution) 3.3±0.16µs 3.5±0.06µs -5.71%
Number Object Access (Full) 169.9±2.46µs 181.2±6.57µs -6.24%
Object Creation (Execution) 4.1±0.33µs 4.4±0.09µs -6.82%
Object Creation (Full) 195.1±3.86µs 201.8±4.76µs -3.32%
RegExp (Execution) 69.1±3.26µs 69.5±1.81µs -0.58%
RegExp (Full) 278.8±6.32µs 289.1±8.29µs -3.56%
RegExp Literal (Execution) 68.2±1.70µs 69.0±3.82µs -1.16%
RegExp Literal (Full) 250.2±5.92µs 260.2±6.22µs -3.84%
RegExp Literal Creation (Execution) 64.2±1.81µs 65.9±2.07µs -2.58%
RegExp Literal Creation (Full) 279.3±7.02µs 285.8±6.93µs -2.27%
Static Object Property Access (Execution) 4.3±0.24µs 4.7±0.10µs -8.51%
Static Object Property Access (Full) 171.7±2.60µs 180.2±4.33µs -4.72%
String Object Access (Execution) 6.3±0.19µs 6.8±0.15µs -7.35%
String Object Access (Full) 175.7±5.46µs 185.2±2.77µs -5.13%
String comparison (Execution) 5.8±0.12µs 6.0±0.26µs -3.33%
String comparison (Full) 176.7±6.34µs 183.4±3.20µs -3.65%
String concatenation (Execution) 4.7±0.11µs 4.9±0.07µs -4.08%
String concatenation (Full) 171.2±5.38µs 177.6±2.93µs -3.60%
String copy (Execution) 3.4±0.09µs 3.7±0.38µs -8.11%
String copy (Full) 165.5±7.74µs 176.1±3.71µs -6.02%
Symbols (Execution) 2.8±0.05µs 3.1±0.06µs -9.68%
Symbols (Full) 162.1±5.30µs 167.8±2.87µs -3.40%

@HalidOdat HalidOdat added the deprecations Issues and PRs related to deprecations. label Aug 1, 2020
@HalidOdat HalidOdat merged commit 8036a49 into master Aug 1, 2020
@HalidOdat HalidOdat deleted the remove/internal-slots branch August 1, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecations Issues and PRs related to deprecations. execution Issues or PRs related to code execution technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant