Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set __proto__ of function instances #604

Merged
merged 2 commits into from
Aug 9, 2020
Merged

Set __proto__ of function instances #604

merged 2 commits into from
Aug 9, 2020

Conversation

54k1
Copy link
Contributor

@54k1 54k1 commented Aug 6, 2020

This Pull Request fixes/closes #531

It changes the following:

  • make_builtin_fn now takes &Interpreter as an argument.
  • Call sites are updated according to the new function signature of make_builtin_fn

@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #604 into master will increase coverage by 0.84%.
The diff coverage is 83.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
+ Coverage   71.67%   72.51%   +0.84%     
==========================================
  Files         177      179       +2     
  Lines       11647    12553     +906     
==========================================
+ Hits         8348     9103     +755     
- Misses       3299     3450     +151     
Impacted Files Coverage Δ
boa/src/builtins/mod.rs 22.58% <0.00%> (-0.76%) ⬇️
boa/src/builtins/object/mod.rs 38.81% <0.00%> (-0.36%) ⬇️
boa/src/builtins/value/val_type.rs 24.00% <0.00%> (-1.00%) ⬇️
boa/src/builtins/value/mod.rs 65.49% <50.00%> (-0.44%) ⬇️
boa/src/builtins/date/mod.rs 69.75% <69.75%> (ø)
boa/src/builtins/value/operations.rs 31.36% <80.00%> (+0.48%) ⬆️
boa/src/builtins/date/tests.rs 99.30% <99.30%> (ø)
boa/src/builtins/object/tests.rs 100.00% <100.00%> (ø)
boa/src/realm.rs 72.22% <100.00%> (+1.63%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8036a49...03e797c. Read the comment docs.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! check my comment :)

boa/src/builtins/function/mod.rs Outdated Show resolved Hide resolved
@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics execution Issues or PRs related to code execution labels Aug 6, 2020
@HalidOdat HalidOdat added this to the v0.10.0 milestone Aug 6, 2020
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me! :)

@HalidOdat HalidOdat marked this pull request as ready for review August 7, 2020 06:50
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, check my comment, for my understanding.

boa/src/builtins/function/mod.rs Show resolved Hide resolved
@HalidOdat HalidOdat requested a review from Razican August 7, 2020 22:29
@HalidOdat HalidOdat merged commit 91d9100 into boa-dev:master Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[builtins] Builtin function doesnt have constructor property
3 participants