-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit testing for Array and String #63
Conversation
Bug: @jasonwilliams const s = new String('\ud834\udf06');
console.log(s.length) Should be |
TODO:
I don't know how to do this. |
Bug(known): const hello = "Hello, ";
hello.concat("world!") waiting for auto box. |
Please review: @jasonwilliams
It is caused by the code in #56, I can't modify it.
But js string length is UTF16/USC2 length, still different on some special cases. |
@GalAster you looking for me to merge this or you wanting to carry on? |
@jasonwilliams It's ready to merge, I'll do the rest after Array format complete. |
Passed:
Array.prototype.join()
Array.prototype.concat()
String.prototype.repeat()
Need fix:
String.prototype.length
String.prototype.concat()