-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Value::to_*int32
to Value::to_*32
#638
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
changed the title
Changed to
Renam Aug 16, 2020
Value::to_*int32
=> Value::to_*32
Value::to_*int32
to Value::to_*32
HalidOdat
changed the title
Renam
Rename Aug 16, 2020
Value::to_*int32
to Value::to_*32
Value::to_*int32
to Value::to_*32
Codecov Report
@@ Coverage Diff @@
## master #638 +/- ##
=======================================
Coverage 72.56% 72.56%
=======================================
Files 179 179
Lines 13259 13259
=======================================
Hits 9621 9621
Misses 3638 3638
Continue to review full report at Codecov.
|
Benchmark for 2d5af41Click to view benchmark
|
Lan2u
approved these changes
Aug 16, 2020
Razican
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #445 (comment)
It changes the following:
Value::to_uint32()
=>Value::to_u32()
Value::to_int32()
=>Value::to_i32()