Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Value::to_*int32 to Value::to_*32 #638

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Conversation

HalidOdat
Copy link
Member

@HalidOdat HalidOdat commented Aug 16, 2020

This PR is related to #445 (comment)

It changes the following:

  • Renamed Value::to_uint32() => Value::to_u32()
  • Renamed Value::to_int32() => Value::to_i32()

@HalidOdat HalidOdat added enhancement New feature or request API labels Aug 16, 2020
@HalidOdat HalidOdat added this to the v0.10.0 milestone Aug 16, 2020
@HalidOdat HalidOdat changed the title Changed to Value::to_*int32 => Value::to_*32 Renam Value::to_*int32 to Value::to_*32 Aug 16, 2020
@HalidOdat HalidOdat changed the title Renam Value::to_*int32 to Value::to_*32 Rename Value::to_*int32 to Value::to_*32 Aug 16, 2020
@codecov
Copy link

codecov bot commented Aug 16, 2020

Codecov Report

Merging #638 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #638   +/-   ##
=======================================
  Coverage   72.56%   72.56%           
=======================================
  Files         179      179           
  Lines       13259    13259           
=======================================
  Hits         9621     9621           
  Misses       3638     3638           
Impacted Files Coverage Δ
boa/src/exec/tests.rs 100.00% <ø> (ø)
boa/src/builtins/math/mod.rs 64.40% <100.00%> (ø)
boa/src/builtins/value/mod.rs 65.51% <100.00%> (ø)
boa/src/builtins/value/tests.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b708b...3cf5526. Read the comment docs.

@github-actions
Copy link

Benchmark for 2d5af41

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 390.5±9.84ns 392.3±19.10ns -0.46%
Arithmetic operations (Full) 271.0±9.02µs 259.8±10.83µs +4.31%
Array access (Execution) 9.2±0.27µs 8.7±0.30µs +5.75%
Array access (Full) 299.3±13.19µs 286.6±13.52µs +4.43%
Array creation (Execution) 3.5±0.10ms 3.4±0.11ms +2.94%
Array creation (Full) 3.9±0.08ms 3.7±0.10ms +5.41%
Array pop (Execution) 1265.7±31.92µs 1197.1±50.49µs +5.73%
Array pop (Full) 1669.7±46.49µs 1633.6±70.88µs +2.21%
Boolean Object Access (Execution) 4.8±0.19µs 4.7±0.39µs +2.13%
Boolean Object Access (Full) 285.9±8.06µs 273.7±10.97µs +4.46%
Create Realm 500.9±22.99ns 514.6±21.17ns -2.66%
Dynamic Object Property Access (Execution) 5.7±0.17µs 5.6±0.24µs +1.79%
Dynamic Object Property Access (Full) 289.1±10.68µs 288.3±14.45µs +0.28%
Expression (Lexer) 2.6±0.13µs 2.6±0.10µs 0.00%
Expression (Parser) 5.4±0.23µs 5.4±0.28µs 0.00%
Fibonacci (Execution) 1032.2±27.33µs 998.9±44.37µs +3.33%
Fibonacci (Full) 1362.8±53.54µs 1301.4±53.77µs +4.72%
For loop (Execution) 25.0±1.17µs 24.3±0.94µs +2.88%
For loop (Full) 309.0±5.73µs 302.2±15.63µs +2.25%
For loop (Lexer) 5.4±0.18µs 5.6±0.23µs -3.57%
For loop (Parser) 14.7±0.60µs 15.0±0.99µs -2.00%
Goal Symbols (Parser) 9.0±0.58µs 9.2±0.35µs -2.17%
Hello World (Lexer) 903.4±46.49ns 888.2±26.52ns +1.71%
Hello World (Parser) 2.2±0.11µs 2.3±0.09µs -4.35%
Long file (Parser) 6.9±0.23ms 6.9±0.19ms 0.00%
Number Object Access (Execution) 3.8±0.09µs 3.7±0.13µs +2.70%
Number Object Access (Full) 291.9±21.09µs 264.9±18.70µs +10.19%
Object Creation (Execution) 4.8±0.12µs 4.7±0.17µs +2.13%
Object Creation (Full) 336.2±16.01µs 326.6±8.80µs +2.94%
RegExp (Execution) 74.0±2.63µs 76.3±3.75µs -3.01%
RegExp (Full) 455.3±12.08µs 431.5±13.48µs +5.52%
RegExp Literal (Execution) 80.1±12.26µs 80.9±4.73µs -0.99%
RegExp Literal (Full) 374.3±15.38µs 367.4±14.67µs +1.88%
RegExp Literal Creation (Execution) 74.3±3.18µs 75.9±2.70µs -2.11%
RegExp Literal Creation (Full) 457.2±30.88µs 430.1±13.36µs +6.30%
Static Object Property Access (Execution) 5.2±0.19µs 5.2±0.20µs 0.00%
Static Object Property Access (Full) 293.0±15.71µs 272.6±8.60µs +7.48%
String Object Access (Execution) 7.3±0.21µs 7.0±0.30µs +4.29%
String Object Access (Full) 286.4±13.06µs 270.1±8.57µs +6.03%
String comparison (Execution) 6.6±0.18µs 6.8±0.32µs -2.94%
String comparison (Full) 280.0±9.28µs 276.3±9.55µs +1.34%
String concatenation (Execution) 5.5±0.15µs 5.7±0.40µs -3.51%
String concatenation (Full) 285.3±16.25µs 268.8±12.24µs +6.14%
String copy (Execution) 4.1±0.13µs 4.0±0.15µs +2.50%
String copy (Full) 274.6±8.21µs 269.6±22.40µs +1.85%
Symbols (Execution) 3.4±0.13µs 3.2±0.15µs +6.25%
Symbols (Full) 262.6±10.28µs 245.0±7.67µs +7.18%

@Razican Razican merged commit 6e7b362 into master Aug 17, 2020
@HalidOdat HalidOdat deleted the rename-value-functions branch August 17, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants