Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark refactor #640

Merged
merged 18 commits into from
Aug 19, 2020
Merged

Benchmark refactor #640

merged 18 commits into from
Aug 19, 2020

Commits on Aug 16, 2020

  1. Update

    neeldug committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    d5a755d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    baebd75 View commit details
    Browse the repository at this point in the history
  3. Moved all bench scripts to consts.rs

    Avoids code repetition between exec, full, lexer & parser.
    neeldug committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    9f3fe05 View commit details
    Browse the repository at this point in the history
  4. Used multiline import.

    Accidentally forgot to run cargo fmt. Fixed now!
    neeldug committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    2f0be91 View commit details
    Browse the repository at this point in the history
  5. Added pub keyword.

    neeldug committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    0619522 View commit details
    Browse the repository at this point in the history
  6. Moving consts to src, subject to move

    Testing to see if benchmark runs here, can be moved elsewhere instead of
    src root.
    neeldug committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    bd77c74 View commit details
    Browse the repository at this point in the history
  7. Moving consts to benches

    Provides more descriptive location for bench scripts.
    neeldug committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    296f05a View commit details
    Browse the repository at this point in the history
  8. Forgot to add to lib

    neeldug committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    1b96fd1 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2020

  1. Trying out include macro for less code repetition.

    bench_scripts contains each static var definition, then is included into
    constants.rs, then imported into each benchmark.
    neeldug committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    05d4e7b View commit details
    Browse the repository at this point in the history
  2. Fixed rust fmt issues...

    🚀 Hopefully works 🚀
    neeldug committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    c6f244d View commit details
    Browse the repository at this point in the history
  3. Incorrect path for includes!

    neeldug committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    ff54dd2 View commit details
    Browse the repository at this point in the history
  4. Using include for each benchmark!

    Works, but includes every constant regardless of whether all are needed,
    also can cause IDE linking issues.
    neeldug committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    c9b24ad View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2e8329b View commit details
    Browse the repository at this point in the history
  6. Benchmark Scripts now modular.

    Fixes #639. Remaining issues: include macro forces each script to import
    unneeded variables and IDE compatibility lost.
    
    Moved all bench scripts to consts.rs
    
    Avoids code repetition between exec, full, lexer & parser.
    
    Used multiline import.
    
    Accidentally forgot to run cargo fmt. Fixed now!
    
    Added pub keyword.
    
    Moving consts to src, subject to move
    
    Testing to see if benchmark runs here, can be moved elsewhere instead of
    src root.
    
    Moving consts to benches
    
    Provides more descriptive location for bench scripts.
    
    Forgot to add to lib
    
    Trying out include macro for less code repetition.
    
    bench_scripts contains each static var definition, then is included into
    constants.rs, then imported into each benchmark.
    
    Fixed rust fmt issues...
    
    🚀 Hopefully works 🚀
    
    Incorrect path for includes!
    
    Using include for each benchmark!
    
    Works, but includes every constant regardless of whether all are needed,
    also can cause IDE linking issues.
    neeldug committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    2d88c68 View commit details
    Browse the repository at this point in the history
  7. Merge branch 'benchmark-refactor' of https://github.com/neeldug/boa i…

    …nto benchmark-refactor
    neeldug committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    c0a0e9e View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2020

  1. Moving rust scripts to javascript.

    Using include_str macro to import consts, perhaps could avoid having
    constants.rs and instead import separately?
    neeldug committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    b32abf4 View commit details
    Browse the repository at this point in the history
  2. Moving all scripts to bench_scripts

    Static imports completed.
    neeldug committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    00cc389 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2020

  1. Moving static includes.

    🚀 Moving static includes to adjacent to functions for better organisation. 🚀
    neeldug committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    1d6a788 View commit details
    Browse the repository at this point in the history