Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default return type from null to undefined #643

Merged
merged 4 commits into from
Aug 19, 2020
Merged

Change default return type from null to undefined #643

merged 4 commits into from
Aug 19, 2020

Conversation

54k1
Copy link
Contributor

@54k1 54k1 commented Aug 19, 2020

This PR changes the default result of statement_list from null to undefined.

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #643 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #643   +/-   ##
=======================================
  Coverage   72.91%   72.92%           
=======================================
  Files         178      178           
  Lines       13226    13230    +4     
=======================================
+ Hits         9644     9648    +4     
  Misses       3582     3582           
Impacted Files Coverage Δ
boa/src/exec/block/mod.rs 68.75% <100.00%> (ø)
boa/src/exec/statement_list.rs 68.75% <100.00%> (ø)
boa/src/exec/tests.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9afbf4...9ec8f6f. Read the comment docs.

@Razican
Copy link
Member

Razican commented Aug 19, 2020

Thanks for the contribution! Could we add a link to the spec and a test for this?

@Razican Razican added this to the v0.10.0 milestone Aug 19, 2020
@Razican Razican added bug Something isn't working execution Issues or PRs related to code execution labels Aug 19, 2020
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is good to go :) We should in the future check for those "Completion" records in the spec too, which will be needed to implement async/await, and would simplify the flow for break/continue/return.

@Razican Razican merged commit 2d1dabb into boa-dev:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants