Added approx_eq! macro for expm1 tests. #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added approx_eq! macro for expm1 tests due to floating point arithmetic inaccuracies, using default ULP & epsilon values. approx_eq! macro does not work for NaN values, however, for tests this should be okay anyway! Solves #664.
Codecov Report
@@ Coverage Diff @@
## master #665 +/- ##
==========================================
+ Coverage 72.69% 72.75% +0.05%
==========================================
Files 179 179
Lines 13409 13421 +12
==========================================
+ Hits 9748 9764 +16
+ Misses 3661 3657 -4
Continue to review full report at Codecov.
|
Removed std feature as was unused in test.
Razican
requested changes
Aug 27, 2020
Razican
added
bug
Refactors tan() unit test, previously unused, to use approx_eq!() macro for assertion to pass on CI.
Razican
approved these changes
Aug 27, 2020
HalidOdat
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added approx_eq! macro for expm1 tests due to floating point arithmetic
inaccuracies, using default ULP & epsilon values. approx_eq! macro does
not work for NaN values, however, for tests this should be okay anyway!
Solves #664.
This Pull Request fixes/closes #664.
It changes the following:
builtins::math::tests::expm1strict equals assertion to approx_eq assertion