Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move property module to root #684

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Move property module to root #684

merged 1 commit into from
Sep 7, 2020

Conversation

HalidOdat
Copy link
Member

Same as #674. It has to be merged first since it is based on that branch.

It changes the following:

  • Move property module to root

@HalidOdat HalidOdat added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics API labels Sep 6, 2020
@HalidOdat HalidOdat added this to the v0.10.0 milestone Sep 6, 2020
@codecov
Copy link

codecov bot commented Sep 6, 2020

Codecov Report

Merging #684 into master will increase coverage by 0.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #684      +/-   ##
==========================================
+ Coverage   72.48%   73.17%   +0.69%     
==========================================
  Files         198      194       -4     
  Lines       14181    14029     -152     
==========================================
- Hits        10279    10266      -13     
+ Misses       3902     3763     -139     
Impacted Files Coverage Δ
boa/examples/classes.rs 0.00% <ø> (ø)
boa/src/builtins/array/mod.rs 76.60% <ø> (+0.26%) ⬆️
boa/src/builtins/bigint/conversions.rs 82.14% <ø> (ø)
boa/src/builtins/bigint/mod.rs 70.00% <ø> (ø)
boa/src/builtins/boolean/mod.rs 36.66% <ø> (ø)
boa/src/builtins/boolean/tests.rs 100.00% <ø> (ø)
boa/src/builtins/console/mod.rs 29.37% <ø> (ø)
boa/src/builtins/console/tests.rs 100.00% <ø> (ø)
boa/src/builtins/date/mod.rs 56.45% <ø> (ø)
boa/src/builtins/date/tests.rs 99.29% <ø> (ø)
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d328e...686d614. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 6, 2020

Benchmark for b9dbd20

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 388.5±25.08ns 390.7±24.77ns -0.56%
Arithmetic operations (Full) 287.0±25.21µs 276.5±25.85µs +3.80%
Array access (Execution) 8.8±0.71µs 8.6±0.42µs +2.33%
Array access (Full) 303.6±18.85µs 293.6±15.17µs +3.41%
Array creation (Execution) 3.3±0.17ms 3.4±0.22ms -2.94%
Array creation (Full) 3.9±0.21ms 3.8±0.19ms +2.63%
Array pop (Execution) 1125.6±61.16µs 1196.6±111.98µs -5.93%
Array pop (Full) 1734.0±100.26µs 1715.9±87.09µs +1.05%
Boolean Object Access (Execution) 5.0±0.32µs 5.2±0.34µs -3.85%
Boolean Object Access (Full) 296.1±17.22µs 279.9±13.06µs +5.79%
Clean js (Execution) 778.7±57.93µs 788.0±53.15µs -1.18%
Clean js (Full) 1115.4±77.05µs 1097.9±57.89µs +1.59%
Clean js (Parser) 40.3±3.07µs 37.2±2.64µs +8.33%
Create Realm 498.7±27.91ns 489.0±33.30ns +1.98%
Dynamic Object Property Access (Execution) 5.9±0.53µs 5.9±0.55µs 0.00%
Dynamic Object Property Access (Full) 296.6±20.82µs 293.4±11.16µs +1.09%
Expression (Parser) 7.3±0.60µs 7.0±0.55µs +4.29%
Fibonacci (Execution) 938.0±53.48µs 941.2±51.06µs -0.34%
Fibonacci (Full) 1276.0±126.19µs 1222.4±65.56µs +4.38%
For loop (Execution) 24.2±1.32µs 25.7±1.99µs -5.84%
For loop (Full) 325.7±23.98µs 321.3±24.13µs +1.37%
For loop (Parser) 19.6±1.20µs 18.9±1.08µs +3.70%
Goal Symbols (Parser) 12.9±1.01µs 13.1±0.98µs -1.53%
Hello World (Parser) 3.4±0.28µs 3.2±0.20µs +6.25%
Long file (Parser) 859.6±50.58ns 838.4±60.85ns +2.53%
Mini js (Execution) 701.7±49.90µs 708.7±40.58µs -0.99%
Mini js (Full) 1041.8±75.55µs 1028.9±79.73µs +1.25%
Mini js (Parser) 35.7±2.43µs 33.5±2.37µs +6.57%
Number Object Access (Execution) 4.1±0.36µs 4.1±0.31µs 0.00%
Number Object Access (Full) 287.3±17.03µs 285.0±17.88µs +0.81%
Object Creation (Execution) 4.8±0.24µs 4.9±0.32µs -2.04%
Object Creation (Full) 348.0±20.61µs 346.2±19.17µs +0.52%
RegExp (Execution) 75.9±5.81µs 74.5±3.24µs +1.88%
RegExp (Full) 382.9±22.90µs 367.4±13.40µs +4.22%
RegExp Literal (Execution) 80.8±8.91µs 75.7±4.04µs +6.74%
RegExp Literal (Full) 386.6±24.30µs 377.4±20.69µs +2.44%
RegExp Literal Creation (Execution) 76.7±5.83µs 72.9±4.32µs +5.21%
RegExp Literal Creation (Full) 449.9±24.89µs 451.7±25.51µs -0.40%
Static Object Property Access (Execution) 5.5±0.35µs 5.3±0.35µs +3.77%
Static Object Property Access (Full) 298.0±23.46µs 287.6±10.46µs +3.62%
String Object Access (Execution) 7.3±0.41µs 7.4±0.38µs -1.35%
String Object Access (Full) 296.8±20.98µs 290.7±15.88µs +2.10%
String comparison (Execution) 7.0±0.73µs 7.5±0.58µs -6.67%
String comparison (Full) 300.3±22.48µs 285.6±15.36µs +5.15%
String concatenation (Execution) 5.6±0.35µs 5.7±0.33µs -1.75%
String concatenation (Full) 287.5±22.86µs 278.7±18.94µs +3.16%
String copy (Execution) 4.3±0.27µs 4.3±0.36µs 0.00%
String copy (Full) 279.2±15.34µs 279.2±16.59µs 0.00%
Symbols (Execution) 3.5±0.20µs 3.5±0.23µs 0.00%
Symbols (Full) 259.5±15.76µs 266.0±21.28µs -2.44%

@HalidOdat HalidOdat merged commit a12ce82 into master Sep 7, 2020
@HalidOdat HalidOdat deleted the move-property-module branch September 7, 2020 08:27
@github-actions
Copy link

github-actions bot commented Sep 7, 2020

Benchmark for bb5b1c3

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 329.8±10.76ns 351.7±16.36ns -6.23%
Arithmetic operations (Full) 233.7±9.20µs 238.3±10.70µs -1.93%
Array access (Execution) 7.6±0.19µs 7.8±0.34µs -2.56%
Array access (Full) 255.6±9.87µs 264.1±13.27µs -3.22%
Array creation (Execution) 2.9±0.07ms 3.0±0.08ms -3.33%
Array creation (Full) 3.3±0.08ms 3.4±0.15ms -2.94%
Array pop (Execution) 1046.8±50.44µs 1051.3±44.37µs -0.43%
Array pop (Full) 1489.9±43.82µs 1521.6±63.19µs -2.08%
Boolean Object Access (Execution) 4.6±0.28µs 4.5±0.34µs +2.22%
Boolean Object Access (Full) 245.0±6.77µs 264.5±25.34µs -7.37%
Clean js (Execution) 696.8±36.82µs 682.9±23.46µs +2.04%
Clean js (Full) 948.9±22.60µs 947.7±25.54µs +0.13%
Clean js (Parser) 33.3±0.89µs 33.9±1.39µs -1.77%
Create Realm 422.3±15.00ns 423.0±21.76ns -0.17%
Dynamic Object Property Access (Execution) 5.2±0.28µs 5.2±0.19µs 0.00%
Dynamic Object Property Access (Full) 248.3±7.56µs 259.6±17.04µs -4.35%
Expression (Parser) 6.1±0.21µs 6.2±0.20µs -1.61%
Fibonacci (Execution) 808.8±23.83µs 808.3±23.29µs +0.06%
Fibonacci (Full) 1059.9±35.74µs 1079.0±37.82µs -1.77%
For loop (Execution) 21.2±0.98µs 21.0±0.61µs +0.95%
For loop (Full) 266.5±7.19µs 269.4±7.78µs -1.08%
For loop (Parser) 16.4±1.25µs 18.1±3.06µs -9.39%
Goal Symbols (Parser) 10.9±0.21µs 11.6±0.93µs -6.03%
Hello World (Parser) 2.8±0.10µs 2.9±0.24µs -3.45%
Long file (Parser) 710.0±20.14ns 728.9±33.79ns -2.59%
Mini js (Execution) 640.5±41.98µs 631.2±40.16µs +1.47%
Mini js (Full) 880.4±32.30µs 923.5±78.82µs -4.67%
Mini js (Parser) 29.4±0.87µs 30.8±1.25µs -4.55%
Number Object Access (Execution) 3.5±0.09µs 3.6±0.17µs -2.78%
Number Object Access (Full) 240.7±8.92µs 255.9±23.66µs -5.94%
Object Creation (Execution) 4.4±0.13µs 4.4±0.20µs 0.00%
Object Creation (Full) 293.9±11.84µs 295.8±9.05µs -0.64%
RegExp (Execution) 65.4±2.14µs 65.8±1.78µs -0.61%
RegExp (Full) 321.5±10.79µs 324.6±12.98µs -0.96%
RegExp Literal (Execution) 68.1±3.75µs 66.9±2.67µs +1.79%
RegExp Literal (Full) 317.7±11.04µs 326.9±11.81µs -2.81%
RegExp Literal Creation (Execution) 62.5±1.95µs 63.4±4.13µs -1.42%
RegExp Literal Creation (Full) 383.7±19.27µs 399.4±18.46µs -3.93%
Static Object Property Access (Execution) 4.7±0.16µs 4.7±0.23µs 0.00%
Static Object Property Access (Full) 245.7±7.65µs 246.5±5.89µs -0.32%
String Object Access (Execution) 6.6±0.29µs 6.7±0.46µs -1.49%
String Object Access (Full) 247.6±16.00µs 253.6±9.48µs -2.37%
String comparison (Execution) 6.1±0.21µs 5.9±0.19µs +3.39%
String comparison (Full) 245.6±7.43µs 257.1±14.14µs -4.47%
String concatenation (Execution) 4.9±0.14µs 5.0±0.25µs -2.00%
String concatenation (Full) 242.5±9.90µs 249.9±11.48µs -2.96%
String copy (Execution) 3.7±0.11µs 3.9±0.27µs -5.13%
String copy (Full) 245.3±13.06µs 257.6±18.68µs -4.77%
Symbols (Execution) 3.1±0.18µs 3.0±0.08µs +3.33%
Symbols (Full) 240.4±16.07µs 228.0±10.22µs +5.44%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants