Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Rename Object::prototype() and Object::set_prototype() #693

Merged
merged 1 commit into from
Sep 12, 2020

Conversation

RageKnify
Copy link
Member

This Pull Request fixes/closes #607.

It changes the following:

  • Rename Object::prototype() to Object::prototype_instance()
  • Rename Object::set_prototype() to Object::set_prototype_instance()

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #693 into master will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
- Coverage   71.70%   71.69%   -0.02%     
==========================================
  Files         199      199              
  Lines       13863    13865       +2     
==========================================
  Hits         9941     9941              
- Misses       3922     3924       +2     
Impacted Files Coverage Δ
boa/src/builtins/json/tests.rs 100.00% <ø> (ø)
boa/src/builtins/object/mod.rs 51.19% <0.00%> (+0.60%) ⬆️
boa/src/exec/tests.rs 100.00% <ø> (ø)
boa/src/value/display.rs 86.36% <ø> (ø)
boa/src/context.rs 60.79% <33.33%> (-1.06%) ⬇️
boa/src/builtins/array/mod.rs 76.65% <50.00%> (ø)
boa/src/builtins/boolean/tests.rs 100.00% <100.00%> (ø)
boa/src/builtins/map/mod.rs 82.25% <100.00%> (ø)
boa/src/object/mod.rs 25.97% <100.00%> (ø)
boa/src/value/mod.rs 69.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d5383b...a12a692. Read the comment docs.

@HalidOdat HalidOdat added the execution Issues or PRs related to code execution label Sep 11, 2020
@HalidOdat HalidOdat added this to the v0.10.0 milestone Sep 11, 2020
@RageKnify
Copy link
Member Author

I don't know why the benchmark check failed.
But I've found the reason for the bad coverage results, as mentioned in xd009642/tarpaulin#351, tarpaulin mistakenly considers chained method calls as not hit if split among multiple lines, resulting in situations like the following where lines 337-339 and 341-343 are considered as not being covered by the tests:
wrong_coverage
In this case cargo fmt increased the number of lines because of the new longer method name and it increased the number of lines considered to not be covered.

@HalidOdat
Copy link
Member

HalidOdat commented Sep 12, 2020

I don't know why the benchmark check failed.

The benchmarks are failing because of an unrelated issue (critcmp is not compatible with criterion v0.3.3 BurntSushi/critcmp#6).

@HalidOdat HalidOdat merged commit 3f06e9a into boa-dev:master Sep 12, 2020
@RageKnify RageKnify deleted the refactor/prototype_instance branch September 12, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execution Issues or PRs related to code execution
Projects
None yet
2 participants