Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Value::to_json order of items in array #699

Merged

Conversation

sele9
Copy link
Contributor

@sele9 sele9 commented Sep 15, 2020

This Pull Request fixes/closes #690.

It changes the following:

  • preserve order of array items on Value::to_json

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #699 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #699      +/-   ##
==========================================
+ Coverage   71.69%   71.73%   +0.03%     
==========================================
  Files         199      199              
  Lines       13865    13866       +1     
==========================================
+ Hits         9941     9947       +6     
+ Misses       3924     3919       -5     
Impacted Files Coverage Δ
boa/src/value/mod.rs 69.75% <100.00%> (+0.07%) ⬆️
boa/src/property/mod.rs 49.65% <0.00%> (-0.70%) ⬇️
boa/src/object/iter.rs 20.20% <0.00%> (+6.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e16927f...045b79a. Read the comment docs.

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Sep 18, 2020
@HalidOdat HalidOdat added this to the v0.10.0 milestone Sep 18, 2020
@HalidOdat HalidOdat merged commit 1a27f06 into boa-dev:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Value::to_json destroy the order of items in an Array
2 participants