Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logs and ensure that forcechoice has enough time to process #107

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Remove logs and ensure that forcechoice has enough time to process #107

merged 5 commits into from
Jul 9, 2024

Conversation

boyuan-chen
Copy link

Remove logs to speed up the Erigon processing time

@boyuan-chen boyuan-chen changed the title Remove logs Remove logs and ensure that forcechoice has enough time to process Jul 8, 2024
mmontour1306
mmontour1306 approved these changes Jul 8, 2024
View reviewed changes
Copy link

@mmontour1306 mmontour1306 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, although we should follow up on the timeout issue. I don't know if hard-coding a larger value is a suitable long-term solution.

jyellick
jyellick approved these changes Jul 9, 2024
View reviewed changes
Copy link

@jyellick jyellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although as noted by GH actions, the cast is unnecessary

@boyuan-chen boyuan-chen merged commit c7498e5 into boba-develop Jul 9, 2024
9 checks passed
@boyuan-chen boyuan-chen deleted the remove-unused-logs branch July 9, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyellick jyellick jyellick approved these changes

@mmontour1306 mmontour1306 mmontour1306 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boyuan-chen @jyellick @mmontour1306