Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return zero base fee for the pre bedrock block #46

Merged
merged 7 commits into from
Oct 17, 2023

Conversation

boyuan-chen
Copy link

@boyuan-chen boyuan-chen commented Sep 26, 2023

We will insert a transition block between the legacy and the new bedrock. The baseFee of the legacy blocks is nil, so we won't modify the Hash() function in the header. This change is to prevent a crash when inserting this transition block.

@boyuan-chen boyuan-chen marked this pull request as draft September 26, 2023 00:18
consensus/misc/eip1559.go Outdated Show resolved Hide resolved
@boyuan-chen boyuan-chen marked this pull request as ready for review October 9, 2023 17:03
@boyuan-chen boyuan-chen merged commit 354888f into boba-develop Oct 17, 2023
7 of 9 checks passed
@boyuan-chen boyuan-chen deleted the fix-basefee-for-pre-bedrock branch October 17, 2023 21:11
jyellick pushed a commit that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants