Alignment with testinprod/op-erigon part 2 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyellick
force-pushed
the
jyellick/more-alignment
branch
from
5a3ea57
to
09fc443
Compare
mmontour1306
approved these changes
Feb 28, 2024
boyuan-chen
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes some struct field ordering in the RPCs, adds some omit-empties, but hopefully doesn't impact anything related to CBOR. In order to modify these structs, I had to re-run code generation, which was broken with modern go, so I ended up upgrading those libs too. This one is worth some testing before deploying.