Issue WordPress#12795 - prefix all orderby keys and use original order

bobbingwide · Jul 2, 2020 · 367c02c · 367c02c
1 parent bfcba33
commit 367c02c
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/compat.php b/lib/compat.php
@@ -480,14 +480,14 @@ function gutenberg_render_block_with_assigned_block_context( $pre_render, $parse
  *
  * @see https://core.trac.wordpress.org/ticket/46294
  *
- * @param string $orderby Current orderby value.
+ * @param string   $orderby Current orderby value.
  * @param WP_Query $query Query object.
  */
 function gutenberg_posts_orderby( $orderby, $query ) {
 	global $wpdb;
-	if ( defined('REST_REQUEST') && REST_REQUEST ) {
-		if ( $query->query['orderby'] === 'menu_order' ) {
-			$orderby = "$wpdb->posts.menu_order,post_title,id asc";
+	if ( defined( 'REST_REQUEST' ) && REST_REQUEST ) {
+		if ( 'menu_order' === $query->query['orderby'] ) {
+			$orderby = "$wpdb->posts.menu_order,$wpdb->posts.post_title,$wpdb->posts.id " . $query->query['order'] ;
 		}
 	}
 	return $orderby;